Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Optimize more queries that could use ReadItem #20693

Closed
3 tasks
AndriySvyryd opened this issue Apr 20, 2020 · 0 comments · Fixed by #34187
Closed
3 tasks

Cosmos: Optimize more queries that could use ReadItem #20693

AndriySvyryd opened this issue Apr 20, 2020 · 0 comments · Fixed by #34187
Assignees
@roji
Labels
area-cosmos area-perf area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-6.0 type-enhancement
Milestone
9.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Apr 20, 2020 •
edited by roji
Loading

  • Match other unitary result methods in addition to FirstOrDefault()
  • Match property access in addition to EF.Property
  • Match any order of PK conditions
@ajcvickers ajcvickers added this to the Backlog milestone Apr 24, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 May 6, 2021
@ajcvickers ajcvickers assigned smitpatel and unassigned AndriySvyryd May 6, 2021
@ajcvickers ajcvickers mentioned this issue May 12, 2021
Closed
@ajcvickers ajcvickers mentioned this issue May 27, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0, Backlog Jul 30, 2021
@smitpatel smitpatel removed their assignment Nov 19, 2021
@ajcvickers ajcvickers mentioned this issue Feb 8, 2024
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, 9.0.0 May 8, 2024
ajcvickers added a commit that referenced this issue Jun 7, 2024
@ajcvickers
Support ReadItem for no-tracking queries
fe4e2b4 
Part of #20693
Part of #33893

There is a lot left to do here, but I'm making a break here to get reviews before it goes too far.

Major changes here are:
- Discover and record properties used to form the JSON `id` in one place.
- Use this to generate ate `id` values without tracking an instance. (Makes no-tracking work, needed for Reload.)
- Be better at detecting only detecting patterns we can later translate.

Next up: be better at detecting non-Find query patterns that we can translate.
@ajcvickers ajcvickers mentioned this issue Jun 7, 2024
Merged
ajcvickers added a commit that referenced this issue Jun 7, 2024
@ajcvickers
Support ReadItem for no-tracking queries
8c4f823 
Part of #20693
Part of #33893

There is a lot left to do here, but I'm making a break here to get reviews before it goes too far.

Major changes here are:
- Discover and record properties used to form the JSON `id` in one place.
- Use this to generate ate `id` values without tracking an instance. (Makes no-tracking work, needed for Reload.)
- Be better at detecting only detecting patterns we can later translate.

Next up: be better at detecting non-Find query patterns that we can translate.
ajcvickers added a commit that referenced this issue Jun 14, 2024
@ajcvickers
Support ReadItem for no-tracking queries
9ff6a70 
Part of #20693
Part of #33893

There is a lot left to do here, but I'm making a break here to get reviews before it goes too far.

Major changes here are:
- Discover and record properties used to form the JSON `id` in one place.
- Use this to generate ate `id` values without tracking an instance. (Makes no-tracking work, needed for Reload.)
- Be better at detecting only detecting patterns we can later translate.

Next up: be better at detecting non-Find query patterns that we can translate.
ajcvickers added a commit that referenced this issue Jun 15, 2024
@ajcvickers
Support ReadItem for no-tracking queries
2e079da 
Part of #20693
Part of #33893

There is a lot left to do here, but I'm making a break here to get reviews before it goes too far.

Major changes here are:
- Discover and record properties used to form the JSON `id` in one place.
- Use this to generate ate `id` values without tracking an instance. (Makes no-tracking work, needed for Reload.)
- Be better at detecting only detecting patterns we can later translate.

Next up: be better at detecting non-Find query patterns that we can translate.
ajcvickers added a commit that referenced this issue Jun 15, 2024
@ajcvickers
Support ReadItem for no-tracking queries (#33927)
0fe066c 
* Support ReadItem for no-tracking queries

Part of #20693
Part of #33893

There is a lot left to do here, but I'm making a break here to get reviews before it goes too far.

Major changes here are:
- Discover and record properties used to form the JSON `id` in one place.
- Use this to generate ate `id` values without tracking an instance. (Makes no-tracking work, needed for Reload.)
- Be better at detecting only detecting patterns we can later translate.

Next up: be better at detecting non-Find query patterns that we can translate.

* Updated version, based on Andriy's comment.

* Code review updates.
roji added a commit to roji/efcore that referenced this issue Jul 4, 2024
@roji
WIP
17738ef 
Closes dotnet#20693
Fixes dotnet#34085
roji added a commit to roji/efcore that referenced this issue Jul 4, 2024
@roji
WIP
fc3e7f7 
Closes dotnet#20693
Fixes dotnet#34085
roji added a commit to roji/efcore that referenced this issue Jul 6, 2024
@roji
WIP
6b0f4fa 
Closes dotnet#20693
Fixes dotnet#34085
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2024
roji added a commit to roji/efcore that referenced this issue Jul 8, 2024
@roji
Redo ReadItem and partition key management
3196621 
Closes dotnet#20693
Closes dotnet#20350
Fixes dotnet#34085
Fixes dotnet#33960
roji added a commit to roji/efcore that referenced this issue Jul 8, 2024
@roji
Redo ReadItem and partition key management
c782058 
Closes dotnet#20693
Closes dotnet#20350
Fixes dotnet#34085
Fixes dotnet#33960
roji added a commit to roji/efcore that referenced this issue Jul 8, 2024
@roji
Redo ReadItem and partition key management
e95cf69 
Closes dotnet#20693
Closes dotnet#20350
Fixes dotnet#34085
Fixes dotnet#33960
@roji roji mentioned this issue Jul 8, 2024
Merged
roji added a commit to roji/efcore that referenced this issue Jul 8, 2024
@roji
Redo ReadItem and partition key management
ff6c096 
Closes dotnet#20693
Closes dotnet#20350
Fixes dotnet#34085
Fixes dotnet#33960
roji added a commit to roji/efcore that referenced this issue Jul 8, 2024
@roji
Redo ReadItem and partition key management
499e04f 
Closes dotnet#20693
Closes dotnet#20350
Fixes dotnet#34085
Fixes dotnet#33960
roji added a commit to roji/efcore that referenced this issue Jul 8, 2024
@roji
Redo ReadItem and partition key management
3592c43 
Closes dotnet#20693
Closes dotnet#20350
Fixes dotnet#34085
Fixes dotnet#33960
@roji roji closed this as completed in 041f4f2 Jul 9, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview6, 9.0.0-preview7 Aug 21, 2024
@roji roji modified the milestones: 9.0.0-preview7, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-cosmos area-perf area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-6.0 type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Cosmos: Redo ReadItem and partition key management roji/efcore
4 participants
@ajcvickers @smitpatel @roji @AndriySvyryd