[release/3.1] Add dependencies for CPD strict in aspnetcore #22120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dougbu
commented
Aug 18, 2020
dougbu
commented
- aligns with [release/3.1] Add dependencies for CPD strict in aspnetcore core-setup#9066 and [release/3.1] Add dependencies for CPD strict in aspnetcore extensions#3417
- unpin System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe Versions
- see [release/3.1] Should we unpin a couple of packages? aspnetcore#24937
- move System.IO.Pipelines version to latest
- aligns with dotnet/core-setup#9066 and dotnet/extensions#3417 - unpin System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe Versions - see dotnet/aspnetcore#24937 - move System.IO.Pipelines version to latest
|
Note this doesn't cover all of the strict coherency requirements for aspnetcore but that'll be easier to check once dependencies flow from core-setup through. Think we're at extensions right now… |
wtgodbe
approved these changes
Aug 18, 2020
|
Hello @dougbu! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
mmitche
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.