Change value generation defaults for numeric keys when using TPC #28529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #28096 Default for relational providers is `Never` Warning is generated by default for relational providers if `OnAdd` is set SQL Server sets the default to `OnAdd` with the `Sequence` strategy
src/EFCore.Relational/Metadata/Conventions/RelationalValueGenerationConvention.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jul 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roji
reviewed
Jul 29, 2022
roji
added a commit
to roji/efcore.pg
that referenced
this pull request
Jul 29, 2022
Basically a copy-paste of: * dotnet/efcore#28477 * dotnet/efcore#28529 Closes of npgsql#2445
roji
added a commit
to roji/efcore.pg
that referenced
this pull request
Jul 29, 2022
Basically a copy-paste of: * dotnet/efcore#28477 * dotnet/efcore#28529 Closes npgsql#2445
|
PG implementation: npgsql/efcore.pg#2456 |
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Jul 29, 2022
Basically a copy-paste of: * dotnet/efcore#28477 * dotnet/efcore#28529 Closes #2445
|
Hey @ajcvickers, @roji does this one also take into account primary key that use value converters to unwrap an numeric value? (i.e. when you have a EntityId class that only wraps an int) It doesn't seems to be working for me and I have to manually opt-in. Not a big deal but it would be nice if that can be either called out on the docs or done by default. |
|
@ilmax Properties of types that wrap a primary key value of some other type are never marked as generated by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28096
NeverOnAddis setOnAddwith theSequencestrategy