Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review items #28709

Merged
merged 1 commit into from
Aug 15, 2022
Merged

API review items #28709

merged 1 commit into from
Aug 15, 2022

Conversation

roji
Copy link
Member

@roji roji commented Aug 14, 2022

  • Append{Update,Delete}Command now accept a higher-level flag for adding a 1 constant to the RETURNING clause.
    • Note that AppendReturningClause still accepts a lower-level string; that's actually being used in SQL Server for the synthetic position value we project out (and could be useful elsewhere).
  • Accept MaxBatchSize in the ReadModificationCommandBatch constructor

Part of #27588

@roji
API review items
268b100 
* Append{Update,Delete}Command now accept a higher-level flag for
  adding a 1 constant to the RETURNING clause.
* Accept MaxBatchSize in the ReadModificationCommandBatch constructor

Part of dotnet#27588
@roji roji requested a review from a team August 14, 2022 12:41
@roji roji merged commit 3291ff5 into dotnet:main Aug 15, 2022
@roji roji deleted the ApiReview branch August 15, 2022 09:29
@ajcvickers ajcvickers mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @AndriySvyryd