Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

31355: SQLite: Add EF.Functions.Unhex #31454

Merged
merged 6 commits into from
Aug 28, 2023
Merged

31355: SQLite: Add EF.Functions.Unhex #31454

merged 6 commits into from
Aug 28, 2023

Conversation

smnsht
Copy link
Contributor

@smnsht smnsht commented Aug 12, 2023 •
edited
Loading

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Fixes #31355

@smnsht smnsht mentioned this pull request Aug 12, 2023
Closed
@bricelam bricelam self-assigned this Aug 13, 2023
@smnsht smnsht marked this pull request as ready for review August 13, 2023 05:43
@bricelam bricelam changed the base branch from main to release/8.0 August 23, 2023 16:30
smnsht and others added 2 commits August 25, 2023 09:34
@smnsht @bricelam
Update src/EFCore.Sqlite.Core/Extensions/SqliteDbFunctionsExtensions.cs
7818ed1 
Changes requested by maintainer

Co-authored-by: Brice Lambson <brice@bricelam.net>
@smnsht
fixing unit tests for requested changes
ab7f505
@smnsht @bricelam
Update src/EFCore.Sqlite.Core/Query/Internal/SqliteHexMethodTranslato…
73826be 
…r.cs

Co-authored-by: Brice Lambson <brice@bricelam.net>
@bricelam bricelam merged commit affd440 into dotnet:release/8.0 Aug 28, 2023
7 checks passed
@smnsht smnsht deleted the 31355 branch August 31, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees

@bricelam bricelam

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite: Add EF.Functions.Unhex
2 participants
@smnsht @bricelam