Sidecars 7, Brazil 0... #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // TODO: Perf: make it faster to check if the property is at the principal end or not | ||
| var foreignKeys = _configuration.Model.EntityTypes.SelectMany( | ||
| e => e.ForeignKeys.Where(f => f.ReferencedProperties.Contains(property))).ToArray(); |
There was a problem hiding this comment.
Consider adding this as an overload of IModel.GetReferencingForeignKeys()
|
|
Assuming no major changes are required because of my feedback.
| @@ -201,10 +240,10 @@ private void InitialFixup(StateEntry entry, EntityState oldState) | |||
| } | |||
|
|
|||
| // Handle case where the new entity is the principal | |||
| foreach (var foreignKey in _stateManager.Model.EntityTypes.SelectMany( | |||
| foreach (var foreignKey in stateManager.Model.EntityTypes.SelectMany( | |||
| e => e.ForeignKeys.Where(f => f.ReferencedEntityType == entityType))) | |||
There was a problem hiding this comment.
Use stateManager.Model.GetReferencingForeignKeys(entityType)
…on SaveChanges) Some primary/principal key values are generated in the store when the entity is saved--for example, for Identity columns. These values are written back into the state entry by the update pipeline. Foreign keys that reference these principal key values also need to be updated with the generated values so that the entire graph stays in sync and so that subsequent commands issued by the update pipeline make use of the newly generated values. Also, if the save transaction is not committed, then these generated values should be discarded. Values written into the state manager by the update pipeline are placed in a temporary transparent sidecar so that they can be discarded later. When a change is detected (or notification is made) that a principal property has changed, then the state manager now finds dependents and updates FK values appropriately. These are also written into the transparent sidecar so that the update pipeline can read them like normal values for subsequent commands, but the values can still be discarded if SaveChanges fails. Still working on some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidecars 7, Brazil 0... (Propagate generated principal values to FKs on SaveChanges)
Some primary/principal key values are generated in the store when the entity is saved--for example, for Identity columns. These values are written back into the state entry by the update pipeline. Foreign keys that reference these principal key values also need to be updated with the generated values so that the entire graph stays in sync and so that subsequent commands issued by the update pipeline make use of the newly generated values. Also, if the save transaction is not committed, then these generated values should be discarded.
Values written into the state manager by the update pipeline are placed in a temporary transparent sidecar so that they can be discarded later. When a change is detected (or notification is made) that a principal property has changed, then the state manager now finds dependents and updates FK values appropriately. These are also written into the transparent sidecar so that the update pipeline can read them like normal values for subsequent commands, but the values can still be discarded if SaveChanges fails.
Still working on some tests.