-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for dotnet/cli#10528 - fix NU1605 error when Maestro updates corefx dependencies #1021
Conversation
…es corefx dependencies
/AzurePipelines run all |
Successfully queued 1 pipeline(s), but failed to queue 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine for now.
Should reduce the number of things that change when we update dependencies soon however. Trend seems to be in the wrong direction.
@@ -63,5 +63,9 @@ | |||
<Uri>https://github.com/dotnet/arcade</Uri> | |||
<Sha>044fa99d22e576fcfaf63f09ee9bba821855dddb</Sha> | |||
</Dependency> | |||
<Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview.19073.11"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we just have to remember to update this and https://github.com/aspnet/Extensions/pull/1021/files#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR19 simultaneously? Seems perilous…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot should take care of updating both files.
@@ -63,5 +63,9 @@ | |||
<Uri>https://github.com/dotnet/arcade</Uri> | |||
<Sha>044fa99d22e576fcfaf63f09ee9bba821855dddb</Sha> | |||
</Dependency> | |||
<Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview.19073.11"> | |||
<Uri>https://github.com/dotnet/corefx</Uri> | |||
<Sha>0000</Sha> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need the correct SHA for the chosen version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be updated by the bot on the next run. Commit sha isn't actually used by anything (yet).
Unblocks #1020
We are getting package downgrade errors due to this implicit package reference: https://github.com/dotnet/sdk/blob/2eb6c546931b5bcb92cd3128b93932a980553ea1/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props#L67-L73.
This works around the problem by updating the implicit version variable.
cc @nguerrera @dsplaisted