Workaround for dotnet/cli#10528 - fix NU1605 error when Maestro updates corefx dependencies #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es corefx dependencies
ryanbrandenburg
approved these changes
Jan 30, 2019
nguerrera
approved these changes
Jan 30, 2019
|
/AzurePipelines run all |
|
Successfully queued 1 pipeline(s), but failed to queue 1 pipeline(s). |
dougbu
approved these changes
Jan 30, 2019
| @@ -63,5 +63,9 @@ | |||
| <Uri>https://github.com/dotnet/arcade</Uri> | |||
| <Sha>044fa99d22e576fcfaf63f09ee9bba821855dddb</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview.19073.11"> | |||
There was a problem hiding this comment.
Will we just have to remember to update this and https://github.com/aspnet/Extensions/pull/1021/files#diff-8b8f08ffbf7b863fb3700c1718eeb4cbR19 simultaneously? Seems perilous…
There was a problem hiding this comment.
The bot should take care of updating both files.
| @@ -63,5 +63,9 @@ | |||
| <Uri>https://github.com/dotnet/arcade</Uri> | |||
| <Sha>044fa99d22e576fcfaf63f09ee9bba821855dddb</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview.19073.11"> | |||
| <Uri>https://github.com/dotnet/corefx</Uri> | |||
| <Sha>0000</Sha> | |||
There was a problem hiding this comment.
Don't we need the correct SHA for the chosen version?
There was a problem hiding this comment.
It will be updated by the bot on the next run. Commit sha isn't actually used by anything (yet).
dsplaisted
approved these changes
Jan 30, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #1020
We are getting package downgrade errors due to this implicit package reference: https://github.com/dotnet/sdk/blob/2eb6c546931b5bcb92cd3128b93932a980553ea1/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props#L67-L73.
This works around the problem by updating the implicit version variable.
cc @nguerrera @dsplaisted