Fix LoggingEventSource to handle null strings #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should file a bug here |
|
Filed #2958 |
|
Do we have any tests for this? |
|
I can add some with this PR. |
|
Can we make this change in one place SetEventData? Just do value ?? “” |
|
You would need to make the swap before you fix the |
|
I got a pretty sweet hack for this |
davidfowl
approved these changes
Mar 6, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…x-logging-event-source Fix LoggingEventSource to handle null strings Commit migrated from dotnet/extensions@8d0fa05
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…x-logging-event-source Fix LoggingEventSource to handle null strings Commit migrated from dotnet/extensions@8d0fa05
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…x-logging-event-source Fix LoggingEventSource to handle null strings Commit migrated from dotnet/extensions@8d0fa05
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
…x-logging-event-source Fix LoggingEventSource to handle null strings\n\nCommit migrated from dotnet/extensions@8d0fa05
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue initially reported in this issue: microsoft/perfview#1092.
EventSource.WriteEventCoredoes not play nicely with null strings passed directly.This fixes #2958.
cc @davidfowl @josalem