Try out more surgical removal of HttpClient logging handler #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep139
reviewed
Jun 8, 2023
src/Libraries/Microsoft.Extensions.Http.Telemetry/Logging/HttpClientLoggingExtensions.cs
Show resolved
Hide resolved
xakep139
reviewed
Jun 8, 2023
| @@ -211,13 +214,14 @@ public static IHttpClientBuilder AddHttpClientLogging(this IHttpClientBuilder bu | |||
| _ = builder.Services | |||
| .AddHttpRouteProcessor() | |||
| .AddHttpHeadersRedactor() | |||
| .AddOutgoingRequestContext() | |||
| .RemoveAll<IHttpMessageHandlerBuilderFilter>(); | |||
There was a problem hiding this comment.
Just for the context, this way is suggested in https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/5.0/http-httpclient-instances-log-integer-status-codes#recommended-action
There was a problem hiding this comment.
Yes, that's the approach the code was using. But @JamesNK was suggesting a better approach which I tried to do here. But it doesn't work, so I must've done something wrong.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow