-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Victorhu/dotnet #71
Victorhu/dotnet #71
Conversation
Hi @victorhurdugaci, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
<add key="NuGet.org" value="https://api.nuget.org/v3/index.json" /> | ||
<add key="AspNetVNext" value="https://www.myget.org/F/aspnetcidev/api/v3/index.json" /> | ||
<add key="DotNet-Core" value="https://myget.org/f/dotnet-core/api/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mirror these packages instead? We did this once before where we were relying on CoreCLR \ Roslyn packages from their feeds. However we're then affected by their package deletion policies which aren't particularly generous. That said, we already mirror packages from dotnet-core, so it would be adding dotnet-cli to the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mirror them once things stabilize. Now there's a lot of churn and we usually need new packages immediately
once you get sign off from @anurse \ @davidfowl |
27f1f76
to
b804031
Compare
e901eaa
to
2137b66
Compare
"Microsoft.Extensions.MemoryPool": "1.0.0-*", | ||
"dnxcore50": { | ||
"dependencies": { | ||
"Microsoft.NETCore.Platforms": "1.0.0-*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally an old version, and not "1.0.1-*"?
Support for dotnet
cc @anurse @davidfowl