Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victorhu/dotnet #71

Merged
merged 1 commit into from
Dec 21, 2015
Merged

Victorhu/dotnet #71

merged 1 commit into from
Dec 21, 2015

Conversation

victorhurdugaci
Copy link

Support for dotnet

cc @anurse @davidfowl

@dnfclas
Copy link

dnfclas commented Dec 15, 2015

Hi @victorhurdugaci, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

<add key="NuGet.org" value="https://api.nuget.org/v3/index.json" />
<add key="AspNetVNext" value="https://www.myget.org/F/aspnetcidev/api/v3/index.json" />
<add key="DotNet-Core" value="https://myget.org/f/dotnet-core/api/v3/index.json" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mirror these packages instead? We did this once before where we were relying on CoreCLR \ Roslyn packages from their feeds. However we're then affected by their package deletion policies which aren't particularly generous. That said, we already mirror packages from dotnet-core, so it would be adding dotnet-cli to the list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mirror them once things stabilize. Now there's a lot of churn and we usually need new packages immediately

@pranavkm
Copy link

:shipit: once you get sign off from @anurse \ @davidfowl

@victorhurdugaci victorhurdugaci force-pushed the victorhu/dotnet branch 5 times, most recently from 27f1f76 to b804031 Compare December 19, 2015 00:18
@victorhurdugaci victorhurdugaci merged commit 2137b66 into dev Dec 21, 2015
@victorhurdugaci victorhurdugaci deleted the victorhu/dotnet branch December 21, 2015 19:16
"Microsoft.Extensions.MemoryPool": "1.0.0-*",
"dnxcore50": {
"dependencies": {
"Microsoft.NETCore.Platforms": "1.0.0-*",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally an old version, and not "1.0.1-*"?

@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants