-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSharp.Core 5.0.1 should not have FSharp.Core.xml in contentFiles #11143
Comments
PR that causes this: #10579 |
This behaviour is by design. Developers of tools who want to ship FSharp.Core with it's associated msbuild file have to perform msbuild FU to deploy the FSharp.Core.xml file. For developers who do not want to deploy the content file with their projects can use this mechanism:
|
@cartermp , we could modify the automagic reference, to have :
|
Yes I think having it as opt-in rather than opt-out would be better |
Yes I'm seeing FSharp.Core.xml actually added to any project that references FSharp.Core 5.0.1. It has to be opt-in, very few people want to distribute this |
Yeah, the description from the PR is this:
Which seems reasonable. But should not result in XML docs being included in the solution tree at the file level. |
Note I kept this as severy-high because starting with 16.9, my understanding is everyone will see this, including new projects. Is that accurate? |
Yes I'm seeing it everywhere |
EDIT: nevermind this layout seems intended. This is still present on the released 5.0.2 package:
|
If people are still seeing this, they may be using Paket, which doesn't honor the defaults set for this implicit package reference. If you're using Paket, there is no current solution, but after this PR is merged, you can use |
I'm finding that this isn't resolved and that, if FSharp.Core is explicitly referenced, it needs
|
The FSharp.Core 5.0.1 package contains the FSharp.Core.xml file under contentFiles. This means Visual Studio shows that file as being part of every FSharp project with that package version installed. This was not an issue in 5.0.0.
Repro steps
example.zip
The text was updated successfully, but these errors were encountered: