-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompileBefore
/CompileAfter
is lost due to the FSharpSourceCodeCompileOrder
target
#17786
Comments
@vzarytovskii This only seem to apply to the items having the metadata before moving groups in |
@auduchinok, |
The file is missing the CompileOrder metadata, making FCS complain about file order. See dotnet/fsharp#17786 (cherry picked from commit 6361b1a985a919a257cb25132f3045d339cdf650) IJ-MR-145514 GitOrigin-RevId: 61870373db11528f1c4fdd9a4f3695b8d7ff985b
The file is missing the CompileOrder metadata, making FCS complain about file order. See dotnet/fsharp#17786 (cherry picked from commit 6361b1a985a919a257cb25132f3045d339cdf650) IJ-MR-145514 GitOrigin-RevId: 61870373db11528f1c4fdd9a4f3695b8d7ff985b
Hi,
We use the knowledge about
CompileBefore
andCompileAfter
extensively in Rider. With the newer SDKs this data is lost because of the new way these files are passed to compiler. Files that were initially added asCompileBefore
are now added toCompile
item collection instead. Even though the final file order is correct, the info about the original item type is lost, which introduces regressions in our case.Could we preserve this knowledge as metadata in the rewritten
Compile
items, please?The text was updated successfully, but these errors were encountered: