-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression on the fix for #50 #321
Comments
It seems to only still be a problem in provided types. And FWIW the member is not present in intellisense, only the tooltip. This seems like a weird scenario - is the provided type inheriting from a record type? |
Yes, the provided type inherits from a record type: https://github.com/fsharp/FSharp.Data/blob/master/src/Xml/XmlRuntime.fs#L61 The original bug was never about IntelliSense, was always about the tooltip |
Is the Record types are supposed to be sealed I thought, I'm surprised you are permitted to inherit from them. Maybe this is a bug that it's allowed at all? |
It only comes from base type. This is not real inheritance, though, it's the base type for an erased type. |
I see the issue, provided types are routed to a different function that was not updated with the original fix. I'm testing a fix now. |
…om base class Fixes dotnet#321
I'm still seeing the _Print member. Either I dind't test it properly last time or the behavior has regressed
Repro:
Go to XmlProvider.fsx in F# Data (https://github.com/fsharp/FSharp.Data/blob/master/docs/content/library/XmlProvider.fsx#L276)
and add the
type t = OutputXml.OrderLine
line:The text was updated successfully, but these errors were encountered: