Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to ship fcs 38.0.1 #10592

Merged
merged 12 commits into from
Dec 4, 2020

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Dec 3, 2020

38.0.1 is a servicing release of fcs it contains:

  1. add check for system assemblies completion #10575 -- add check for system assemblies completion
  2. Fix net sdk references discovery #10569 -- Fix net sdk references discovery
  3. Fix FSC nuget package dependencies. Use FSharp.Org tool Icon as package icon. #10588 -- Fix FSC nuget package dependencies.

Also contains test case fixes to run on the re-imaged vms.

There will be an additional preview release of everything in master branch with the version# 39.0.1-preview-*

/cc @baronfel , @dsyme , @cartermp

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but should there also be placeholder links in the release-notes.md file that correspond to the version?

@KevinRansom KevinRansom merged commit d2ef973 into dotnet:release/fcs Dec 4, 2020
@baronfel
Copy link
Member

Poking this, what's the cadence for this release? I wasn't sure if this MR was a signal to expect FCS to be pushed to nuget or what.

@KevinRansom
Copy link
Member Author

@baronfel , we are having problems uploading it to nuget. Apparently the system has changed again and now Microsoft needs to be a co-owner of the repo, I believe Phillip is working out the details.

Kevin

@baronfel
Copy link
Member

Thanks for the update, Kevin!

@KevinRansom
Copy link
Member Author

@baronfel you should have heard @brettfo and I curse when validation failed, fortunately @brettfo had just been through it with another package so at least he recognized what was going on. It didn't mean we were happy about it though ... no sir.

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* add check for system assemblies completion

* add check for system assemblies completion

* add check for system assemblies completion

* merge issues

* add FCS release definition links

* Fix FSC nuget package dependencies.  Use FSharp.Org tool Icon as package icon. (dotnet#10588)

* src/fsharp/DotNetFrameworkDependencies.fs

* System.Config

* version

* Update bframework refencing (dotnet#10502)

* Fix release notes link

* temp (dotnet#10506)

Co-authored-by: Don Syme <donsyme@fastmail.com>
Co-authored-by: Brett V. Forsgren <brettfo@microsoft.com>
@KevinRansom KevinRansom deleted the cp_fcsdependencies branch January 21, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants