Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcebuild perf perhaps #16860

Merged
merged 29 commits into from
May 8, 2024
Merged

Sourcebuild perf perhaps #16860

merged 29 commits into from
May 8, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Mar 12, 2024 •
edited
Loading

Fixes: #16833
Fixes: #16969

  • Speeds up sourcebuild by 10-20 % which is pretty decent.
  • The effect on repo builds is mostly neutral, perhaps marginally faster builds.
  • Switches proto compiler to a Ready2Run compiled coreclr compiler
  • Fixes the deterministic build test to work correctly with a netsdk proto build.

@KevinRansom KevinRansom requested a review from a team as a code owner March 12, 2024 06:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom marked this pull request as draft March 12, 2024 06:52
vzarytovskii
vzarytovskii requested changes Mar 12, 2024
View reviewed changes
Sourcebuild.sln Outdated Show resolved Hide resolved
eng/Build.ps1 Show resolved Hide resolved
src/FSharp.Build/FSharp.Build.fsproj Outdated Show resolved Hide resolved
src/FSharp.Compiler.Interactive.Settings/FSharp.Compiler.Interactive.Settings.fsproj Outdated Show resolved Hide resolved
src/FSharp.DependencyManager.Nuget/FSharp.DependencyManager.Nuget.fsproj Outdated Show resolved Hide resolved
src/fsc/fsc.targets Outdated Show resolved Hide resolved
src/fsi/fsi.targets Outdated Show resolved Hide resolved
tests/Directory.Build.props Outdated Show resolved Hide resolved
vsintegration/Templates.Directory.Build.props Outdated Show resolved Hide resolved
@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 12, 2024
@KevinRansom KevinRansom reopened this Mar 13, 2024
@MichaelSimons MichaelSimons mentioned this pull request Mar 13, 2024
Closed
@KevinRansom KevinRansom deleted the investigatebuild branch March 21, 2024 22:24
@KevinRansom KevinRansom restored the investigatebuild branch March 21, 2024 23:32
@KevinRansom KevinRansom reopened this Mar 21, 2024
@KevinRansom KevinRansom force-pushed the investigatebuild branch 5 times, most recently from de05f8e to 978002a Compare March 29, 2024 17:31
@KevinRansom KevinRansom force-pushed the investigatebuild branch 5 times, most recently from 6b53b85 to 22800d7 Compare April 1, 2024 18:59
T-Gro
T-Gro reviewed Apr 9, 2024
View reviewed changes
src/fsc/fsc.targets Outdated Show resolved Hide resolved
vzarytovskii
vzarytovskii approved these changes Apr 19, 2024
View reviewed changes
eng/SourceBuildPrebuiltBaseline.xml Outdated Show resolved Hide resolved
src/Compiler/FSharp.Compiler.Service.fsproj Show resolved Hide resolved
src/FSharp.Build/FSharp.Build.fsproj Show resolved Hide resolved
src/FSharp.Core/FSharp.Core.fsproj Show resolved Hide resolved
@KevinRansom KevinRansom enabled auto-merge (squash) May 7, 2024 10:23
@KevinRansom
Copy link
Member Author

/cc @dotnet/source-build-internal

@KevinRansom KevinRansom merged commit 8d1e873 into dotnet:main May 8, 2024
32 checks passed
This was referenced May 20, 2024
Closed
Closed
@tmds tmds mentioned this pull request Jun 12, 2024
Closed
@KevinRansom KevinRansom deleted the investigatebuild branch June 25, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the netcore compiler appears to cause the determinism tests to fail Speed up sourcebuild, and build
5 participants
@KevinRansom @vzarytovskii @MichaelSimons @T-Gro @psfinaki