Use alternative way of ignoring measures when detecting integral types #17040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `typeEquivAux EraseMeasures` instead of calling `stripMeasuresFromTy` and passing the result into `typeEquiv` when determining whether the range operator's type argument is an integral type. I would have expected the outcome to be the same for both approaches, but that appears not always to be the case (though it often is).
❗ Release notes required
|
vzarytovskii
approved these changes
Apr 15, 2024
edgarfgp
approved these changes
Apr 15, 2024
auto-merge was automatically disabled
April 15, 2024 11:38
Head branch was pushed to by a user without write access
psfinaki
approved these changes
Apr 15, 2024
2 tasks
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #16650. Fixes #17025.
typeEquivAux EraseMeasuresinstead of callingstripMeasuresFromTyand passing the result intotypeEquivwhen determining whether the range operator's type argument is an integral type. I originally assumed that the outcome would be the same for both approaches, but that appears not always to be the case (though it often is).Notes
(.. ..)/start..step..finishinfor-loops. Units of measure cannot currently be used at all with the range operator(..)/start..finish(due I think to its use ofLanguagePrimitives.GenericOne, which also does not support units of measure; see, e.g., Allow units of measure in sequence ranges fsharp/fslang-suggestions#535, etc.).Checklist