Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beforecompile #17057

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Beforecompile #17057

merged 9 commits into from
Apr 26, 2024

Conversation

KevinRansom
Copy link
Member

Fixes #16771

For years CompileBefore and CompileAfter have been used to position generated files in the FSharp project build.

However, they are not WellKnown supported dotnet sdk collections. This PR changes this by allowing BeforeCompile and AfterCompile to be specified as metadata attached to CompileItems.

Note:

  1. In order to maintain compatibility with existing projects that may use CompileBefore and CompileAfter we maintain support for them
  2. The existing FSharp repo build will continue to use CompileBefore and CompileAfter collections, to avoid rewriting their build targets.

@KevinRansom KevinRansom requested a review from a team as a code owner April 16, 2024 19:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 16, 2024
@T-Gro
Copy link
Member

T-Gro commented Apr 19, 2024

Does this need docs changes?

@KevinRansom KevinRansom merged commit 7e1b266 into dotnet:main Apr 26, 2024
32 checks passed
vzarytovskii added a commit that referenced this pull request Apr 29, 2024
@vzarytovskii
Revert "Beforecompile (#17057)"
7f771f7 
This reverts commit 7e1b266.
@vzarytovskii vzarytovskii mentioned this pull request Apr 29, 2024
Merged
vzarytovskii added a commit that referenced this pull request Apr 29, 2024
@vzarytovskii
Revert "Beforecompile (#17057)" (#17099)
b08afc5 
This reverts commit 7e1b266.
@dotnet-bot dotnet-bot mentioned this pull request May 11, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 21, 2024
Closed
@Smaug123 Smaug123 mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FSharps use of CompileBefore for file ordering leads to issues with other SDK components
3 participants
@KevinRansom @T-Gro @vzarytovskii