-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few super-minor compiler perf improvements #17130
Merged
psfinaki
merged 8 commits into
dotnet:main
from
brianrourkeboll:minor-perf-improvements
May 13, 2024
Merged
A few super-minor compiler perf improvements #17130
psfinaki
merged 8 commits into
dotnet:main
from
brianrourkeboll:minor-perf-improvements
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Override `ToString` on `BuildPhase`. * Cache the delegate passed into `ConcurrentDictionary.GetOrAdd` where possible. See dotnet#14582, fsharp/fslang-suggestions#1083, etc.
❗ Release notes required
|
vzarytovskii
approved these changes
May 10, 2024
psfinaki
reviewed
May 10, 2024
En3Tho
reviewed
May 10, 2024
brianrourkeboll
commented
May 10, 2024
* I don't think I fully understand why, but I did some rough microbenchmarking, and for some reason the `GetOrAdd` and `Interlocked.Increment` on a ref cell technique is actually something like twice as fast as `AddOrUpdate`.
psfinaki
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw some of these show up when I did a quick profile of FSharp.Compiler.ComponentTests, which take the longest to run of all the tests.
Override
ToString
onBuildPhase
; the automaticprintf
-based implementation does a lot more work than it needs to for a fieldless DU.Example
fsharp/src/Compiler/Driver/ParseAndCheckInputs.fs
Lines 410 to 428 in fec36c9
I guess I could have just changed the above to this instead:
But maybe it's best to speed up any potential future stringifications anyway, just in case.
Cache the delegate passed into
ConcurrentDictionary.GetOrAdd
where possible. See Cache delegates #14582, Emit direct delegates when possible fsharp/fslang-suggestions#1083, etc.Remove a redundant
StringBuilder
in one place.Checklist