Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: recover on missing union case fields #17452

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Parser: recover on missing union case fields #17452

merged 5 commits into from
Aug 1, 2024

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Jul 26, 2024 •
edited
Loading

Adds recovery for various unfinished union case declarations:

type U =
    | A of int *
type U =
    | A of int * int *
type U =
    | A of int * * int
type U =
    | A of * int * int

Also fixes range calculations. Otherwise, recovered nodes would use wrong range that spans past the node end.

@auduchinok auduchinok requested a review from a team as a code owner July 26, 2024 17:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@vzarytovskii vzarytovskii enabled auto-merge (squash) July 27, 2024 17:34
@auduchinok auduchinok mentioned this pull request Jul 29, 2024
Merged
auto-merge was automatically disabled July 30, 2024 13:23

Head branch was pushed to by a user without write access

@auduchinok auduchinok force-pushed the parser-unionCaseRepr branch from 948cfc4 to fc06f28 Compare July 30, 2024 13:23
@auduchinok
Copy link
Member Author

This is ready.

@auduchinok auduchinok force-pushed the parser-unionCaseRepr branch 2 times, most recently from 1fe5207 to b66c1b3 Compare July 31, 2024 12:00
@auduchinok auduchinok force-pushed the parser-unionCaseRepr branch from b66c1b3 to 4ea778e Compare August 1, 2024 11:00
@psfinaki psfinaki merged commit d2d38e3 into dotnet:main Aug 1, 2024
30 checks passed
@auduchinok auduchinok deleted the parser-unionCaseRepr branch August 1, 2024 13:14
This was referenced Aug 13, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarfgp edgarfgp edgarfgp approved these changes

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auduchinok @vzarytovskii @psfinaki @edgarfgp