Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable F# 9.0 #17500

Merged
merged 15 commits into from
Aug 9, 2024
Merged

Enable F# 9.0 #17500

merged 15 commits into from
Aug 9, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Aug 6, 2024 •
edited
Loading

Fixes #16739

@KevinRansom KevinRansom requested a review from a team as a code owner August 6, 2024 20:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/9.0.100.md
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@KevinRansom KevinRansom changed the title Fixes #17499 - UnionCase doesn't seem to be a valid target for the DefaultAugmentationAttribute Enable F# 9.0 Aug 6, 2024
@KevinRansom KevinRansom enabled auto-merge (squash) August 9, 2024 02:44
psfinaki
psfinaki approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know the context for all the changes, but where I know it - LGTM.

edgarfgp
edgarfgp approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@edgarfgp edgarfgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I contributed it looks ok 👍🏻

@KevinRansom KevinRansom merged commit 4324c4f into dotnet:main Aug 9, 2024
30 checks passed
This was referenced Aug 13, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
pedersorensen
pedersorensen reviewed Oct 1, 2024
View reviewed changes
docs/release-notes/.FSharp.Compiler.Service/9.0.100.md
@@ -22,5 +22,5 @@
* Optimize metadata reading for type members and custom attributes. ([PR #17364](https://github.com/dotnet/fsharp/pull/17364))
* Enforce `AttributeTargets` on unions. ([PR #17389](https://github.com/dotnet/fsharp/pull/17389))
* Ensure that isinteractive multi-emit backing fields are not public. ([Issue #17439](https://github.com/dotnet/fsharp/issues/17438)), ([PR #17439](https://github.com/dotnet/fsharp/pull/17439))

* Enable FSharp 9.0 Language Version ([Issue #17497](https://github.com/dotnet/fsharp/issues/17438)), [PR](https://github.com/dotnet/fsharp/pull/17500)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Not sure if I'm approaching this issue correctly, but the link points to #17438 while the display text is #17497.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, fixing it here.

@psfinaki psfinaki mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianrourkeboll brianrourkeboll brianrourkeboll left review comments

@psfinaki psfinaki psfinaki approved these changes

@pedersorensen pedersorensen pedersorensen left review comments

@edgarfgp edgarfgp edgarfgp approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
6 participants
@KevinRansom @vzarytovskii @pedersorensen @psfinaki @brianrourkeboll @edgarfgp