Migrate VisualFSharp tests to Xunit #17751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
T-Gro
reviewed
Sep 18, 2024
T-Gro
reviewed
Sep 18, 2024
vsintegration/tests/UnitTests/LegacyProjectSystem/Tests.ProjectSystem.Configs.fs
Show resolved
Hide resolved
T-Gro
reviewed
Sep 18, 2024
psfinaki
commented
Sep 20, 2024
abonie
approved these changes
Sep 20, 2024
KevinRansom
approved these changes
Sep 23, 2024
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
* Migrate last Nunit tests to Xunit * up * up * up * Update TestLib.LanguageService.fs * up * up * up * Remove unused tests * one more * up --------- Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #13654
Last NUnit test suite. Finally!
This was basically a mechanical replacement of Nunit test primitives with Xunit test primitives.
TestLib.LanguageServicerequired a bit more attention, otherwise things worked more or less out of the box. Tests still run in the single-threaded fashion, otherwise most of them fail.Tests run and pass:
In particular, 2183 tests are passing and 428 are skipped.
Tests also failed before, while this was in progress (1, 2). So they are executed :)
Note: despite this removes the last NUnit test suite, this is not a complete eradication of NUnit just yet. This will be done separately. We're nearly there!