Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 17786 - CompileBefore/CompileAfter is lost due to the FSharpSourceCodeCompileOrder target #17791

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Fix 17786 - CompileBefore/CompileAfter is lost due to the FSharpSourceCodeCompileOrder target #17791

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1408099
Fix 17786
KevinRansom Sep 25, 2024
ee5bdca
Merge branch 'main' into fix17786
KevinRansom Sep 25, 2024
61fc877
Merge branch 'main' into fix17786
KevinRansom Sep 26, 2024
567936c
Merge branch 'main' into fix17786
KevinRansom Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/FSharp.Build/Microsoft.FSharp.NetSdk.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,18 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
<PackageReference>
<GeneratePathProperty>true</GeneratePathProperty>
</PackageReference>

<CompileBefore>
<CompileOrder>CompileBefore</CompileOrder>
</CompileBefore>

<CompileAfter>
<CompileOrder>CompileAfter</CompileOrder>
</CompileAfter>

<CompileLast>
<CompileOrder>CompileLast</CompileOrder>
</CompileLast>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add CompileFirst?

I see its usage in FSharpSourceCodeCompileOrder here:

fsharp/src/FSharp.Build/Microsoft.FSharp.Targets

Line 262 in 6cdcc3c

<__Sources Include="@(Compile->WithMetadataValue('CompileOrder', 'CompileFirst'))" />

and in FSharp.Core here:

fsharp/src/FSharp.Core/FSharp.Core.fsproj

Line 80 in 6cdcc3c

<Compile Include="prim-types-prelude.fsi" CompileOrder="CompileFirst">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinRansom This hasn't been resolved. 😞

</ItemDefinitionGroup>

</Project>
Loading