-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: remove dependency on CurrentDirectory ("test.ok" files) #17815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
T-Gro
reviewed
Sep 30, 2024
T-Gro
reviewed
Sep 30, 2024
T-Gro
reviewed
Oct 1, 2024
Tested contributor scenario on WIndows:
Tests running fine. |
I also added BUILDING_USING_DOTNET condition to FSharpSuite.Tests. Now
Verifies the relevant test successfully runs |
T-Gro
reviewed
Oct 2, 2024
T-Gro
approved these changes
Oct 2, 2024
0101
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cherrypick from #17662.
A lot of FSharpSuite tests write a "test.ok" file to current dir to signal success. This is bad because current directory is a shared resource.
This makes them write to stdout instead.
Not pretty either, but Console.Out can be very simply intercepted in a multi-threaded way to unblock running those tests in parallel.
Inspired by #17709.