-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parsing table cache bug #17816
fix parsing table cache bug #17816
Conversation
|
The contents of the cache are semantically just pairs of numbers, right? ? |
Yes |
Can you add the "no release notes required" label? |
Description
This is a fix for a bug in
Internal.Utilities.Text.Parsing.Implementation.AssocTable
.The cache algorithm in
AssocTable.Read
relies on unused cache locations being marked.In the implementation of the algorithm in AssocTable,
0
was used as marker.However,
0
is also a valid key. This fix changes the marker to-1
.(In the context of my "scoped nowarn" work, a new token type that I added was not parsed correctly. It took me some time to find the reason.)