-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Internal error when analysing incomplete inherit member #17905
Conversation
❗ Release notes required
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit: I generally think keeping pattern matching flat where possible (instead of adding nested match
expressions) makes the top-level match easier to understand, but feel free to ignore if you disagree.
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
878597e
to
362bdfc
Compare
@psfinaki Sorry to bother you again. Could you help me update the last salsa test https://dev.azure.com/dnceng-public/public/_build/results?buildId=850191&view=ms.vss-test-web.build-test-results-tab&runId=22075436&resultId=108303&paneView=debug. Trying to do it using the CI is really painful :( |
@edgarfgp there you go (hopefully), pushed to your branch. You cannot want the same thing to be both expected and unexpected in the list of completions :) Judging by the name of the test, I think this PR decreases the amount of contexts without completions - for better or worse. |
This is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Description
Fixes #17902
Checklist