Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Internal error when analysing incomplete inherit member #17905

Merged
merged 14 commits into from
Oct 24, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Oct 21, 2024

Description

Fixes #17902

Checklist

  • Test cases added
  • Release notes entry updated

Copy link
Contributor

github-actions bot commented Oct 21, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

Copy link
Contributor

@brianrourkeboll brianrourkeboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: I generally think keeping pattern matching flat where possible (instead of adding nested match expressions) makes the top-level match easier to understand, but feel free to ignore if you disagree.

src/Compiler/Service/ServiceParseTreeWalk.fs Outdated Show resolved Hide resolved
src/Compiler/Driver/GraphChecking/FileContentMapping.fs Outdated Show resolved Hide resolved
src/Compiler/Service/ServiceParsedInputOps.fs Outdated Show resolved Hide resolved
src/Compiler/Service/ServiceParsedInputOps.fs Outdated Show resolved Hide resolved
edgarfgp and others added 5 commits October 21, 2024 18:55
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
@edgarfgp edgarfgp force-pushed the fix-17902 branch 3 times, most recently from 878597e to 362bdfc Compare October 22, 2024 15:07
@edgarfgp
Copy link
Contributor Author

@psfinaki Sorry to bother you again. Could you help me update the last salsa test https://dev.azure.com/dnceng-public/public/_build/results?buildId=850191&view=ms.vss-test-web.build-test-results-tab&runId=22075436&resultId=108303&paneView=debug. Trying to do it using the CI is really painful :(

@psfinaki
Copy link
Member

@edgarfgp there you go (hopefully), pushed to your branch. You cannot want the same thing to be both expected and unexpected in the list of completions :)

Judging by the name of the test, I think this PR decreases the amount of contexts without completions - for better or worse.

@edgarfgp edgarfgp marked this pull request as ready for review October 23, 2024 16:45
@edgarfgp edgarfgp requested a review from a team as a code owner October 23, 2024 16:45
@edgarfgp
Copy link
Contributor Author

This is ready

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@psfinaki psfinaki merged commit ee8af8a into dotnet:main Oct 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Internal error when analyzing incomplete inherit member
5 participants