Fix missing nullness warning in case of multiple applicable candidates for method resolution (e.g. string and ROS<char>) #17918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
❗ Release notes required
|
…uct-do-not-report-nullness-warning
psfinaki
approved these changes
Oct 25, 2024
…uct-do-not-report-nullness-warning
abonie
approved these changes
Nov 7, 2024
T-Gro
deleted the
17880-nullness-issue---static-methods-on-struct-do-not-report-nullness-warning
branch
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17880 .
This was happening when method resolution had more than 1 correct candidate, e.g. 1 direct and 1 via op_Implicit.
The condition to avoid warning in case of speculative overloads was originally there to avoid duplicate warnings, but this has since been eliminated by a change in type inference for arguments.
There is an existing test for duplicate message which is still passing (not visible in the PR diff, because the tests did not have to be changed).
The same for speculativeMethodOVerloading special case for uselessWarning feature - all existing tests are passing as before with exactly the same diagnostics set.