Typed Unused Opens analyzer #3803
Conversation
|
@dotnet-bot test this please |
|
It needs almost 2 minutes to process TypeChecker.fs. |
|
@dotnet-bot test Ubuntu14.04 Release_fcs Build please |
|
It's ready. It's slow on large files, but works correctly. As @dsyme implements fsharp/fsharp-compiler-docs#830, it will be very easy to make this analyzer very fast. We should push Roslyn team to implement priority and parallel execution of analyzers. Any progress on this? |
|
@dotnet-bot test this please |
|
I'm not sure whether the _fsc failures are expected to pass? Certainly pr's today have beem green. |
|
It reports fcs tests errors. Not sure. @vasily-kirichenko could you please rebase and if things are still red we need to take a look at that unit test |
|
Fixed. |
|
So it really caught its first bug?
Am 28.10.2017 16:49 schrieb "Vasily Kirichenko" <notifications@github.com>:
… Fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3803 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNIm29rZfNC6eDbUWip9_o4L4M2LWks5swz76gaJpZM4QDZc0>
.
|
|
@forki Yes. It was related to the fact that provided types are not supported on netstandard. Great work :) |
|
Lol. You are welcome.
But on more serious note: it's good to deal with this early. Maybe that
takes a bit of work away from @dsyme when he does the merges
Am 28.10.2017 19:52 schrieb "Vasily Kirichenko" <notifications@github.com>:
… @forki <https://github.com/forki> Yes. It was related to the fact that
provided types are not supported on netstandard. Great work :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3803 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNK7-B9ng9qklwEJfUHm9-MgrewaXks5sw2nkgaJpZM4QDZc0>
.
|
|
@dsyme I cannot see why the FCS repo is needed anymore now. |
|
Thanks for this Kevin |
|
@vasily-kirichenko Re FCS - see fsharp/fsharp-compiler-docs#834 and let's discuss there. |
…arations-2 Typed Unused Opens analyzer
This is a rewrite of the analyzer. It uses
EntityRef listcorresponding to each open declaration, gets its content and check if any symbol is used in the open declaration scope. No more long id fiddling and such. It should work precisely, always (no false positives, no missed unused opens).As a side effect, module usages are now found in open declarations: