Fix 362 - Depickling assertion followed by nullref internal errors in units-of-measure case #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts a debug-only message for #362 into a check, a warning and advice. The warning is not attributed to a specific line number, rather we use "range0".
I don't know if it's worth adding a test case for this. When using it manually on #362 we now get this:
unknown(1,1): warning FS3186: An error occurred while reading the F# metadata no de at position 10 in table 'itypars' of assembly 'a, Version=0.0.0.0, Culture=ne utral, PublicKeyToken=null'. The node had no matching declaration. Please report this warning. You may need to recompile the F# assembly you are using.which is of some help, though it is followed by the errors as before. (I'm loathe to raise a hard "error" condition here on import as in many cases the assembly will still be usable.)