Fix #199 - Explicitly set custom F# editor settings if they are missing #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On package load, check if any of the custom F# settings are somehow missing from the settings store. Explicitly set them to their desired defaults if they are indeed missing. I've added this to the language service package since this is guaranteed to load any time the project system package is loaded, but the converse is not true (e.g. open loose F# script file without opening a solution). fixes dotnet#199
| // If cloud-synced settings have already been applied or the user has made an explicit change, do nothing | ||
| match settingsManager.TryGetValue(settingName) with | ||
| | Microsoft.VisualStudio.Settings.GetValueResult.Missing, _ -> | ||
| settingsManager.SetValueAsync(settingName, defaultValue, false) |> ignore |
There was a problem hiding this comment.
SetValueAsync return a Task, await the task completion instead of ignore?
There was a problem hiding this comment.
There is not much use in awaiting this. It is a plain Task, there is no return value to inspect. Even if it fails, there is no particular retry or error handling we would implement. In theory if settingsManager falls out of scope and gets GCed it might cancel its child tasks or something, but practically speaking this won't happen for a shared VS service.
On the Roslyn side they take a similar approach of fire and forget.
|
/cc @jasonmalinowski for review of IDE stuff |
|
Approved 6/10 by ML Shiproom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking with VS platform people, this is the suggested workaround for cases where VS fails to apply the custom F# settings from the General profile.
F# only specifies
3(edit: 4) settings that deviate from the editor defaults, so it's only these 3 that need special care, AFAICT.I'm still talking with the platform people to make sure this is the correct approach, but figured I'd send the PR to get review early.
ref #199