Fixes: #4822 --- Support for arbitrary value in AssemblyInformationalVersionAttribute

[KevinRansom]

Fix: #4822, #5052
The F# compiler erroneously validated that the AssemblyInformationalVersionAttribute started with a Version number.

This changes relaxes that requirement.

[brettfo]

In our own code we've suppressed this warning, can you update this line?

[KevinRansom]

@brettfo can you take another look.

[vincenzoml]

I need this fix in dotnet-sdk and I'm not sure I understand the above messages; is it already released? In which sdk version?

[cartermp]

This should be in the latest .NET SDK as per: dotnet/cli#10199

If it is not, then @KevinRansom can speak more towards this fix.

[vincenzoml]

I get this warning, but the functionality works fine and I get my whole version string in the AssemblyInformationalVersion attribute.

warning FS2003: The attribute System.Reflection.AssemblyInformationalVersionAttribute specified version '0.5.1.1-WIP', but this value is invalid and has been ignored [/home/vincenzo/data/jesus/repos/imgql/src/VoxLogicA.fsproj]

[KevinRansom]

This fix will appear in VS2019 preview 1. VS2017.9 does not have the fix.

VS2017.9 was intended to be a stabilizing build, with a very high bar for and a very low number of bug fixes.

[cartermp]

@KevinRansom It's in the latest .NET SDK and @vincenzoml was able to confirm it works for him. Since this doesn't have VS bits, I'm not sure if a particular VS releases matters in this case...

[KevinRansom]

@cartermp, I am now a little confused:

This is the dev15.9 branch source code: https://github.com/Microsoft/visualfsharp/blob/dev15.9/src/fsharp/TypeChecker.fs#L17350

This is the source code for the dev15.8 branch:
https://github.com/Microsoft/visualfsharp/blob/dev15.8/src/fsharp/TypeChecker.fs#L17344

As you can in both see it warns on invalid AssemblyInformationalVersionAttribute. This source was used to build the distributed VS2017.8 desktop and coreclr compilers, VS2017.9 desktop compiler, and the associated release of the dotnet cli.

Master branch and dev16.0 and dev16.0 preview 1 all contain the fix. So to the best of my understanding no release or preview has yet shipped with this fix.

Kevin

[cartermp]

I'm confused as well, as it's not clear why a fix that is in the .NET SDK 2.1.5xx is not available in .NET SDK 2.1.5xx .. I suppose we'll learn one way or another when dev16 preview 1 is out.

[KevinRansom]

@cartermp

This is a decompilation of the compiler dll from :
dotnet\sdk\2.1.500

It seems to have the check for AssemblyInformationalVersionAttribute
I hope this clears it up for you.

        string item = str.item;
        Tast.EntityRef ref2 = _arg3.item1;
        Range.range range = @const.item2;
        string fullName = ref2.Deref.CompiledRepresentationForNamedType.FullName;
        if (!string.Equals(fullName, "System.Reflection.AssemblyInformationalVersionAttribute"))
        {
            if (string.Equals(fullName, "System.Reflection.AssemblyFileVersionAttribute"))
            {
                if (TypeChecker.isValid@17346(item, null))
                {
                    goto Label_00CD;
                }
            }
            else if (!string.Equals(fullName, "System.Reflection.AssemblyVersionAttribute") || TypeChecker.isValid@17346(item, null))
            {
                goto Label_00CD;
            }
        }
        else if (TypeChecker.isValid@17346(item, null))
        {
            goto Label_00CD;
        }
        Exception exn = new ErrorLogger.Error(SR.fscBadAssemblyVersion(fullName, item), range);
        ErrorLogger.ErrorLoggerExtensions.ErrorLogger.Warning(ErrorLogger.CompileThreadStatic.ErrorLogger, exn);
        return null;
    Label_00CD:
        return null;
    Label_0101:
        return null;
    }
}