Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing string concatenations to use String.Concat overloads #5570

Merged
merged 22 commits into from
Nov 7, 2018
Merged

Optimizing string concatenations to use String.Concat overloads #5570

merged 22 commits into from
Nov 7, 2018

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Aug 29, 2018 •
edited
Loading

Resolves this issue: #5560

  • Added test cases
  • [Maybe?] Optimize direct calls to String.Concat rather than look at addition operators

@TIHan TIHan force-pushed the string-concat-opt branch from 8da39ac to 27d1f6f Compare September 5, 2018 19:27
@TIHan TIHan changed the base branch from dev16.0 to master September 5, 2018 19:28
@TIHan TIHan force-pushed the string-concat-opt branch from 27d1f6f to 500a47e Compare September 5, 2018 19:29
@TIHan TIHan closed this Sep 6, 2018
@TIHan TIHan reopened this Sep 6, 2018
@TIHan TIHan changed the title [WIP] Optimizing string concatenations to use String.Concat overloads Optimizing string concatenations to use String.Concat overloads Sep 7, 2018
forki
forki approved these changes Sep 8, 2018
View reviewed changes
Copy link
Contributor

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

src/fsharp/Optimizer.fs Outdated Show resolved Hide resolved
src/fsharp/Optimizer.fs Outdated Show resolved Hide resolved
@TIHan
Copy link
Contributor Author

TIHan commented Sep 12, 2018

Will need @dsyme 's review on this before merge.

@TIHan TIHan closed this Sep 13, 2018
@TIHan TIHan reopened this Sep 13, 2018
@TIHan TIHan changed the title Optimizing string concatenations to use String.Concat overloads [WIP] Optimizing string concatenations to use String.Concat overloads Sep 13, 2018
@TIHan
Copy link
Contributor Author

TIHan commented Sep 13, 2018

I reviewed this again myself; I need to make a few adjustments to the code and tests.

@TIHan TIHan changed the title [WIP] Optimizing string concatenations to use String.Concat overloads Optimizing string concatenations to use String.Concat overloads Sep 17, 2018
@TIHan
Copy link
Contributor Author

TIHan commented Sep 17, 2018

Ok, this is ready. After adding more tests, I feel much better about it.

@cartermp cartermp requested a review from dsyme September 17, 2018 20:25
@TIHan TIHan closed this Sep 17, 2018
@TIHan TIHan reopened this Sep 17, 2018
@forki
Copy link
Contributor

forki commented Oct 3, 2018

Ping

@TIHan
Copy link
Contributor Author

TIHan commented Oct 25, 2018

@KevinRansom I'll change it to compare emitted IL in the right folder.

@dsyme I'll need your review on this before we can try to merge this.

@TIHan TIHan force-pushed the string-concat-opt branch from 195d39e to d1f8428 Compare November 6, 2018 19:03
@TIHan
Copy link
Contributor Author

TIHan commented Nov 7, 2018 •
edited
Loading

This is now ready and has a better way to handle tests for checking IL.

KevinRansom
KevinRansom approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@KevinRansom
Copy link
Member

@dsyme, this looks good to me, I'm going to merge it. Please take a look and let us know if you feel ny changes are necessary.

@KevinRansom KevinRansom merged commit f2de3ba into dotnet:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

@forki forki forki approved these changes

@dsyme dsyme Awaiting requested review from dsyme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TIHan @forki @KevinRansom