Fix #5729

[gdziadkiewicz]

No description provided.

[dsyme]

Great! Link to the bug: #5729

[dnfclas]

All CLA requirements met.

[cartermp]

@gdziadkiewicz Are you seeking a review? If so, if you could:

• Sign the .NET CLA
• Mark this PR as ready for review

Then we can take a look.

[gdziadkiewicz]

@cartermp It is still work in progress. I was recently busy and even managed to forget about this PR, but I will make it review ready this week.

[cartermp]

@gdziadkiewicz No rush!

[realvictorprm]

You pushed 0 commits? Github bug lol

[realvictorprm]

@gdziadkiewicz pushed 0 commits.

[cartermp]

@realvictorprm It's possible to push empty commits, which will re-trigger CI.

[gdziadkiewicz]

@cartermp Are there any plans to fix this CI error? It seems to be also present on master ATM

[KevinRansom]

@brettfo

[cartermp]

@gdziadkiewicz Yes, we have an internal email thread going with infrastructure folks. It doesn't appear to be related to our codebase.

[brettfo]

@gdziadkiewicz The issue is present on all Windows jobs trying to restore FSharp.Core 4.6.2. There is no issue if it's trying to restore 4.7.0 (like in the release/dev16.3 branch) nor is there an issue on non-Windows machines. I'm having some internal conversations to try and figure out why this package isn't getting restored.

I have a temporary workaround that I'll be creating a PR for soon

[brettfo]

#7424 should fix the issue. I'll watch and merge that one as soon as it's ready.

Once that's in you may need to rebase or close/open this PR to trigger a new merge and build.

[brettfo]

#7424 is now in; you should be able to rebase (or otherwise force a re-merge) and get the tests to do something sane.

[gdziadkiewicz]

Thanks @brettfo , now it builds fine on the build server. @cartermp From my perspective this is ready to be reviewed.

[cartermp]

Change seems reasonable. @dsyme?

[cartermp]

Give that FSharp.Core 4.7 is locked, this will be in F# vNext