-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --pathmap #6609
Conversation
cc @brettfo can you take a look at this PR instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
conflict ... /help tests fail, baseline updates probably.
|
Thanks @KevinRansom - I've just updated the baselines. The determinism test (which I haven't changed) that failed is potentially flaky. In the ...but there is no timeout/pause to ensure this gap as far as I can see? |
Re-running tests as it looks like @dsyme - any idea why the compiler is sometimes choosing different names? It actually seems important to determinism more widely. |
Looks like a different flaky test now:
|
It's green! Let's not sneeze in the wrong direction here, for fear of angering another flaky test... |
Fixes #5213, #3812
Supersedes #5801