Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flags to turn off features we don't need, add "--tracing" option #12

Merged
merged 4 commits into from
Jul 24, 2020

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jul 24, 2020

Adds optional "--tracing" argument to enable tracing, usage:

./build.sh --tracing

Also, turns off some features we definitely don't need
doesn't save much, ~40kb or so.

@EgorBo EgorBo requested review from lewing, akoeplinger and kg and removed request for lewing July 24, 2020 12:42
@EgorBo EgorBo marked this pull request as draft July 24, 2020 13:16
@EgorBo EgorBo marked this pull request as ready for review July 24, 2020 14:24
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well turn them off anyway.

@EgorBo EgorBo merged commit 4d77f7b into dotnet:maint/maint-67 Jul 24, 2020
akoeplinger pushed a commit that referenced this pull request Aug 25, 2020
This change merges the Taiwan calendar changes (PR #8) and the runtime Nuget changes (PR #9)
into the maint/maint-67 branch. The version number has been bumped to 67.1.0.2 for these changes.

Note: To preserve the history of the commits, this change will need to be merged as a "merge commit", rather than the usual squash merge approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants