Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Reduced ICU files for HybridGlobalization #349

Merged
merged 6 commits into from
May 15, 2023

Conversation

mkhamoyan
Copy link

@mkhamoyan mkhamoyan commented May 9, 2023

First version of reduced ICU files for HybridGlobalization, Mobile. Contributes to dotnet/runtime#80689.

HybridGlobalization is an optional function that can be switched on by the developer by adding

<HybridGlobalization>true</HybridGlobalization>

to the ios/tvos/maccatalyst project.

By this PR icudt_hg_mobile.json is added. In comparison with icudt_mobile.json below resources are filtered out from locales_tree

  "-/NumberElements/*/symbols",
  "-/calendar/Gregorian/AmPmMarkers",
  "-/calendar/Gregorian/AmPmMarkersAbbr",
  "-/calendar/Gregorian/AmPmMarkersNarrow",

Below are the results comparing current full icu file size with new file size.
icudt_hybrid.dat will be created for iOS/tvOS/macCatalyst platforms.

Target arch icudt.dat icudt_hybrid.dat
maccatalyst x64 1 998 352 bytes 1 983 408 bytes

File size is decreased with ~1%.

cc @SamMonoRT

@mkhamoyan mkhamoyan requested review from ilonatommy and directhex May 9, 2023 13:24
@mkhamoyan mkhamoyan marked this pull request as ready for review May 9, 2023 13:26
@mkhamoyan mkhamoyan self-assigned this May 9, 2023
@mkhamoyan mkhamoyan requested a review from steveisok May 9, 2023 14:05
@mkhamoyan
Copy link
Author

@directhex could you please build and update eng/prebuilts/mobile/icudt_hybrid.dat ? In my machine each time it creates different size dat file from 2 MB to 2.5 MB

@mkhamoyan
Copy link
Author

As discussed with @directhex , pushed icudt_hybrid.dat size is the same as in his locale build.

@mkhamoyan mkhamoyan merged commit 90cbc4d into dotnet:dotnet/main May 15, 2023
@mkhamoyan mkhamoyan deleted the hybrid_icu_filters branch May 15, 2023 09:06
steveisok pushed a commit to steveisok/icu that referenced this pull request May 25, 2023
Added icudt_hybrid.dat file for mobile and added new filters for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants