Remove runtime patch that disabled package validation #13000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbussell - Can you link to the runtime PR that address the stability issues? What branch were these made in? I am wondering if they were backported to 6.0. |
|
Here is where the patch was merged into release/6.0. Here is the issue we were using to track backporting the flaky build fixes |
MichaelSimons
approved these changes
Jan 11, 2022
We haven't backported them to 6.0. I will work on that for the 6.0.3 release. I'll let you know so that you can remove the patch on 6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/source-build#2708
We initially created this patch for runtime's release/6.0 branch to work around some reliability issues with package validation: dotnet/runtime#60881
I ported this patch to main but apparently the reliability issues were fixed a while ago: dotnet/runtime#63601 (comment). As a result, this patch isn't necessary anymore.