Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Add support for arm platform #14470

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

ayakael
Copy link

@ayakael ayakael commented Sep 11, 2022

Expected behavior

As prebuilt SDKs are provided for arm by Microsoft, source-build should support ARM build.

Actual behavior

Per dotnet/source-build#2781, source-build does not support arm.

Proposed modifications

This pull request modifies existing Platform and Architecture logics to parse arch information correctly when BuildArchitecture=arm

Varia

release/6.0.1xx version: #13378

Made as part of Alpine Linux dotnet6 packaging project, see dotnet/source-build#2782

@ayakael
Copy link
Author

ayakael commented Sep 11, 2022

Rebased to main to see if checks fail here as well.

@ayakael ayakael changed the title Add support for arm platform [main] Add support for arm platform Sep 11, 2022
@ayakael
Copy link
Author

ayakael commented Sep 26, 2022

@MichaelSimons Who can I ping to review this? It'd be nice to include this in rc2 and next verson of dotnet6.

@MichaelSimons
Copy link
Member

@MichaelSimons Who can I ping to review this? It'd be nice to include this in rc2 and next verson of dotnet6.

@dsplaisted - Can you please review else add the appropriate code reviewer?

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this looks good.

@ayakael
Copy link
Author

ayakael commented Sep 27, 2022

@ayakael
Copy link
Author

ayakael commented Sep 27, 2022

Per @omajid in #13378, reverted proposal by @kasperk81

@MichaelSimons
Copy link
Member

@crummel - please review.

@crummel
Copy link

crummel commented Oct 21, 2022

I rebased this on latest main and I'm reviewing now.

@crummel crummel merged commit 8d3930c into dotnet:main Oct 21, 2022
ayakael added a commit to ayakael/installer that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants