[main] Add support for arm platform #14470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayakael
force-pushed
the
main-arm-support
branch
from
90e1947
to
8da3a95
Compare
|
Rebased to main to see if checks fail here as well. |
ayakael
changed the title
|
@MichaelSimons Who can I ping to review this? It'd be nice to include this in rc2 and next verson of dotnet6. |
@dsplaisted - Can you please review else add the appropriate code reviewer? |
dsplaisted
approved these changes
Sep 27, 2022
ayakael
force-pushed
the
main-arm-support
branch
from
098d538
to
50673e5
Compare
|
This was referenced Sep 27, 2022
ayakael
force-pushed
the
main-arm-support
branch
from
50673e5
to
6362fb1
Compare
|
Per @omajid in #13378, reverted proposal by @kasperk81 |
MichaelSimons
approved these changes
Oct 7, 2022
|
@crummel - please review. |
crummel
force-pushed
the
main-arm-support
branch
from
6362fb1
to
1e7182a
Compare
|
I rebased this on latest main and I'm reviewing now. |
crummel
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
As prebuilt SDKs are provided for arm by Microsoft, source-build should support ARM build.
Actual behavior
Per dotnet/source-build#2781, source-build does not support arm.
Proposed modifications
This pull request modifies existing
PlatformandArchitecturelogics to parse arch information correctly whenBuildArchitecture=armVaria
release/6.0.1xx version: #13378
Made as part of Alpine Linux dotnet6 packaging project, see dotnet/source-build#2782