Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Source-Build 7.0.102 January 2023 Updates #15251

Merged
merged 13 commits into from
Jan 17, 2023
Merged

.NET Source-Build 7.0.102 January 2023 Updates #15251

merged 13 commits into from
Jan 17, 2023

Conversation

dotnet-sb-bot
Copy link

Source-build updates for the .NET 7.0.2 / 7.0.102 January 2023 release.

@dotnet-sb-bot dotnet-sb-bot requested a review from a team as a code owner January 10, 2023 22:40
@MichaelSimons
Copy link
Member

@crummel - with this change, should we remove the OverrideBootstrapVersions and then don't we need to bootstrap the CI legs that don't match the rid of the new PSB artifacts?

@MichaelSimons
Copy link
Member

I suspect this is blocked on #15239.

@lbussell lbussell mentioned this pull request Jan 11, 2023
Merged
@MichaelSimons
Copy link
Member

I believe this is going to require a fix for dotnet/source-build#3210.

@MichaelSimons
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crummel
Add bootstrap workaround.
2629ea4 
This works around dotnet/source-build#3210 by
specifying the portable version of ILAsm (the same as the non-portable
version) and using that version for bootstrapping.
@crummel
Copy link

crummel commented Jan 13, 2023

Had a typo in the PSB PVP, uploaded a new version.

@MichaelSimons
Copy link
Member

I was expecting a couple more changes.

  1. SBRP needs to be updated to no longer reference the portable il tool packages
  2. The bootstrap project needs to be updated to reference the non-portable version properties.

@MichaelSimons MichaelSimons mentioned this pull request Jan 17, 2023
Merged
@crummel
Copy link

crummel commented Jan 17, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichaelSimons
Copy link
Member

@crummel - There appears to be issues with the PSB archive.

+ docker run --rm -v /mnt/vss/_work/1/a/tarball:/tarball -w /tarball mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8-20220809204800-17a4aab ./build.sh --clean-while-building --online

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

@MichaelSimons MichaelSimons merged commit 4192499 into dotnet:release/7.0.1xx Jan 17, 2023
This was referenced Jan 18, 2023
Merged
Closed
Merged
@MichaelSimons MichaelSimons mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbussell lbussell lbussell approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
Area-SourceBuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotnet-sb-bot @MichaelSimons @crummel @lbussell