DotNetHelper: fix IsMonoRuntime being initialized before extracting the sdk. #15646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/DotNetHelper.cs
Show resolved
Hide resolved
MichaelSimons
approved these changes
Mar 6, 2023
|
@MichaelSimons will this auto-merge? |
No - so I took care of it. |
|
Thanks! I'm looking forward to see our CI build turn green this time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mono detection added in #15341.
The code that checks for mono runs against a directory that is created by the tests.
It worked for me locally because I had ran the tests before.
On a fresh run, it always returned
IsMonoRuntime = falsebecause the sdk was not extracted yet.This fixes the detection by running it after the sdk is extracted.
@crummel @MichaelSimons ptal.
cc @omajid