Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVP workaround for system.drawing.common removal #15876

Merged
merged 1 commit into from
Mar 21, 2023
Merged

PVP workaround for system.drawing.common removal #15876

merged 1 commit into from
Mar 21, 2023

Conversation

MichaelSimons
Copy link
Member

This PR contains the following changes:

  1. Added a more robust workaround for System.Drawing.Common being removed from Runtime than what was added in Add System.Common.Drawing prebuilt #15868. As I result of this, I removed the System.Drawing.Common prebuilt added in that PR.
  2. Added the following prebuilts - Eventually these should be new SBRPs but it required the 7.0 targeting pack which we do not want to add yet until all repos have been upgraded to target net8.0.
  3. System.Drawing.Common,7.0.0
  4. Microsoft.Win32.SystemEvents,7.0.0

Once merged, I will log a follow-up issue to cleanup this workaround as part of the preview 3 public PR.

@MichaelSimons MichaelSimons requested a review from a team as a code owner March 20, 2023 22:20
@MichaelSimons
Copy link
Member Author

I will backport this to Preview 3 once approved.

@MichaelSimons MichaelSimons merged commit 7cc8a16 into dotnet:main Mar 21, 2023
@MichaelSimons MichaelSimons deleted the SDC-removal branch March 21, 2023 13:56
MichaelSimons added a commit to MichaelSimons/installer that referenced this pull request Mar 21, 2023
@MichaelSimons
PVP workaround for system.drawing.common removal (dotnet#15876)
05226fa
@MichaelSimons MichaelSimons mentioned this pull request Mar 21, 2023
Merged
MichaelSimons added a commit that referenced this pull request Mar 21, 2023
@MichaelSimons
PVP workaround for system.drawing.common removal (#15876) (#15888)
8e58000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crummel crummel crummel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelSimons @crummel