Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/sdk #17187

Merged
merged 73 commits into from
Oct 23, 2023
Merged

[main] Update dependencies from dotnet/sdk #17187

merged 73 commits into from
Oct 23, 2023

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Aug 15, 2023 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 9.0.0-alpha.1.23477.3 to 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0: from 9.0.0-alpha.1.23477.3 to 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0: from 9.0.0-alpha.1.23477.3 to 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.SharedFramework.x64.9.0: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.TargetingPack.x64.9.0: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref.Internal: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • dotnet-dev-certs: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • dotnet-user-jwts: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • dotnet-user-secrets: from 9.0.0-alpha.1.23512.8 to 9.0.0-alpha.1.23522.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-alpha.1.23477.3 to 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 9.0.0-alpha.1.23431.2 to 9.0.0-alpha.1.23520.4 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 9.0.0-alpha.1.23477.3 to 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 9.0.0-alpha.1.23431.2 to 9.0.0-alpha.1.23520.4 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.FSharp.Compiler: from 12.8.0-beta.23510.3 to 12.8.0-beta.23519.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.fsharp: from 8.0.200-beta.23510.3 to 8.0.200-beta.23519.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.Test.Sdk: from 17.9.0-preview-23509-01 to 17.9.0-preview-23519-02 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.ILLink.Tasks: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.Net.Compilers.Toolset: from 4.9.0-1.23511.8 to 4.9.0-1.23520.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.Build: from 17.9.0-preview-23511-03 to 17.9.0-preview-23519-03 (parent: Microsoft.NET.Sdk)
    • NuGet.Build.Tasks: from 6.9.0-preview.1.13 to 6.9.0-preview.1.17 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-alpha.1.23512.2 to 9.0.0-alpha.1.23523.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.Deployment.DotNet.Releases: from 2.0.0-preview.1.23478.2 to 2.0.0-preview.1.23509.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.deployment-tools: from 8.0.0-preview.6.23478.2 to 8.0.0-preview.6.23509.2 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: f8ee08b0-6c3d-485a-6895-08db0a1df366
  • Build: 20231023.12
  • Date Produced: October 23, 2023 7:17:01 PM UTC
  • Commit: 9709a5aebf08ebae7dfe6937e5e5ffd0c346fb46
  • Branch: refs/heads/main

@dotnet-maestro
Copy link
Author

Notification for subscribed users from https://github.com/dotnet/sdk:

@dotnet/domestic-cat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/sdk) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@oleksandr-didyk oleksandr-didyk requested a review from a team as a code owner August 17, 2023 13:58
@Tanya-Solyanik
Copy link
Member

@mmitche - This PR is blocking WInForms insertion into installers, Is anyone working on it?

@mmitche
Copy link
Member

mmitche commented Aug 18, 2023

@Tanya-Solyanik Main is now 9.0 so I expect that this branch will have less attention for a little while.

/cc @marcpopMSFT

@marcpopMSFT
Copy link
Member

Correct, our priority at the moment is the RC1 and RC2 branches.

@marcpopMSFT
Copy link
Member

Looking at the failures, the two classes of test failures will require the 9.0 runtime to flow. We could maybe workaround it by hardcoding some values now but it's better to wait.

@mthalman mthalman mentioned this pull request Aug 25, 2023
Closed
@RussKie RussKie mentioned this pull request Sep 3, 2023
Closed
@mthalman mthalman mentioned this pull request Sep 6, 2023
Merged
@nagilson
Copy link
Member

PIT issue: its trying to build with .NET 9 which is not ready yet, the runtime probably needs to flow dotnet/sdk#35048

@nagilson nagilson enabled auto-merge September 12, 2023 20:22
@mthalman
Copy link
Member

Here's the source-build failure that's occurring:

/vmr/src/sdk/artifacts/source-build/self/src/src/Cli/dotnet/dotnet.csproj : error NU1605: Warning As Error: Detected package downgrade: Microsoft.Build from 17.8.0-preview-23431-02 to 17.8.0-preview-23418-03. Reference the package directly from the project to select a different version.  [/vmr/src/sdk/artifacts/source-build/self/src/source-build.slnf]
/vmr/src/sdk/artifacts/source-build/self/src/src/Cli/dotnet/dotnet.csproj : error NU1605:  Microsoft.DotNet.Cli -> Microsoft.Build.Runtime 17.8.0-preview-23431-02 -> Microsoft.Build (>= 17.8.0-preview-23431-02)  [/vmr/src/sdk/artifacts/source-build/self/src/source-build.slnf]
/vmr/src/sdk/artifacts/source-build/self/src/src/Cli/dotnet/dotnet.csproj : error NU1605:  Microsoft.DotNet.Cli -> Microsoft.Build (>= 17.8.0-preview-23418-03) [/vmr/src/sdk/artifacts/source-build/self/src/source-build.slnf]
/vmr/src/sdk/artifacts/source-build/self/src/src/Cli/dotnet/dotnet.csproj : error NU1109: Detected package downgrade: Microsoft.Build.Tasks.Core from 17.8.0-preview-23431-02 to centrally defined 17.8.0-preview-23418-03. Update the centrally managed package version to a higher version.  [/vmr/src/sdk/artifacts/source-build/self/src/source-build.slnf]
/vmr/src/sdk/artifacts/source-build/self/src/src/Cli/dotnet/dotnet.csproj : error NU1109:  Microsoft.DotNet.Cli -> Microsoft.Build.Runtime 17.8.0-preview-23431-02 -> Microsoft.Build.Tasks.Core (>= 17.8.0-preview-23431-02)  [/vmr/src/sdk/artifacts/source-build/self/src/source-build.slnf]
/vmr/src/sdk/artifacts/source-build/self/src/src/Cli/dotnet/dotnet.csproj : error NU1109:  Microsoft.DotNet.Cli -> Microsoft.Build.Tasks.Core (>= 17.8.0-preview-23418-03) [/vmr/src/sdk/artifacts/source-build/self/src/source-build.slnf]

What this means is that sdk has a dependency on version 17.8.0-preview-23431-02 of msbuild. But the build is producing version 17.8.0-preview-23418-03. This is a coherency issue. As can be seen in the coherency updates in the body of this PR, it includes this older, out-of-sync, version of MSBuild:

Microsoft.Build: from 17.8.0-preview-23414-01 to 17.8.0-preview-23418-03 (parent: Microsoft.NET.Sdk)

@mmitche - Do you know why this is happening?

@mmitche
Copy link
Member

mmitche commented Sep 13, 2023

Looking. I'm guessing the incoherency is leaking in from some tooling dependency. It would end up being a pre-built if it succeeded in building.

@RussKie RussKie force-pushed the darc-main-d813792c-eeee-4e40-9f7c-567a78c653dd branch from 35aca79 to cf3a569 Compare September 14, 2023 02:43
@RussKie
Copy link
Member

RussKie commented Sep 14, 2023

All jobs emit the following warning:

D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(141,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(141,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(148,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(148,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(155,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(155,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(162,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(162,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(169,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(169,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(176,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(176,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(331,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageName'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(331,9): message : MSB4120: Item 'BundledLayoutPackage' definition within target references itself via (qualified or unqualified) metadatum 'PackageVersion'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref [D:\a\_work\1\s\src\redist\redist.csproj]

@RussKie RussKie force-pushed the darc-main-d813792c-eeee-4e40-9f7c-567a78c653dd branch 4 times, most recently from 0a091e1 to 228204d Compare September 14, 2023 03:18
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 14, 2023
@RussKie RussKie force-pushed the darc-main-d813792c-eeee-4e40-9f7c-567a78c653dd branch from 228204d to e80758f Compare September 14, 2023 03:26
@RussKie
Copy link
Member

RussKie commented Sep 14, 2023

The source build is failing with

/__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23461.2/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
/__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23461.2/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
/__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23461.2/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : Package IDs are:
/__w/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23461.2/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : Newtonsoft.Json.13.0.3

@RussKie
Copy link
Member

RussKie commented Sep 14, 2023

The Windows build is failing to install the runtime:

D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(397,5): error : Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/8.0.0-rc.1.23412.3/windowsdesktop-runtime-9.0.0-alpha.1.23456.3-win-x64.zip, https://dotnetbuilds.blob.core.windows.net/public/WindowsDesktop/8.0.0-rc.1.23412.3/windowsdesktop-runtime-9.0.0-alpha.1.23456.3-win-x64.zip [D:\a\_work\1\s\src\redist\redist.csproj]
##[error]src\redist\targets\GenerateLayout.targets(397,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/8.0.0-rc.1.23412.3/windowsdesktop-runtime-9.0.0-alpha.1.23456.3-win-x64.zip, https://dotnetbuilds.blob.core.windows.net/public/WindowsDesktop/8.0.0-rc.1.23412.3/windowsdesktop-runtime-9.0.0-alpha.1.23456.3-win-x64.zip
D:\a\_work\1\s\src\redist\targets\GenerateLayout.targets(397,5): error : Failed to download file using addresses in Uri and/or Uris. [D:\a\_work\1\s\src\redist\redist.csproj]

@mthalman
Copy link
Member

Source-build is getting this error:

    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277: Found conflicts between different versions of "Microsoft.Build.Locator" that could not be resolved. [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277: There was a conflict between "Microsoft.Build.Locator, Version=1.5.5.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd" and "Microsoft.Build.Locator, Version=1.6.1.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd". [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:     "Microsoft.Build.Locator, Version=1.5.5.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd" was chosen because it was primary and "Microsoft.Build.Locator, Version=1.6.1.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd" was not. [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:     References which depend on "Microsoft.Build.Locator, Version=1.5.5.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd" [/vmr/src/format/artifacts/source-build/self/package-cache/microsoft.build.locator/1.5.5/lib/netcoreapp3.1/Microsoft.Build.Locator.dll]. [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:         /vmr/src/format/artifacts/source-build/self/package-cache/microsoft.build.locator/1.5.5/lib/netcoreapp3.1/Microsoft.Build.Locator.dll [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:           Project file item includes which caused reference "/vmr/src/format/artifacts/source-build/self/package-cache/microsoft.build.locator/1.5.5/lib/netcoreapp3.1/Microsoft.Build.Locator.dll". [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:             /vmr/src/format/artifacts/source-build/self/package-cache/microsoft.build.locator/1.5.5/lib/netcoreapp3.1/Microsoft.Build.Locator.dll [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:     References which depend on "Microsoft.Build.Locator, Version=1.6.1.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd" []. [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:         /vmr/src/format/artifacts/source-build/self/package-cache/microsoft.codeanalysis.workspaces.msbuild/4.8.0-3.23462.3/lib/net8.0/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.dll [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:           Project file item includes which caused reference "/vmr/src/format/artifacts/source-build/self/package-cache/microsoft.codeanalysis.workspaces.msbuild/4.8.0-3.23462.3/lib/net8.0/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.dll". [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:             /vmr/src/format/artifacts/source-build/self/package-cache/microsoft.codeanalysis.workspaces.msbuild/4.8.0-3.23462.3/lib/net8.0/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.dll [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]
    /vmr/.dotnet/sdk/8.0.100-rc.1.23410.12/Microsoft.Common.CurrentVersion.targets(2364,5): error MSB3277:             /vmr/src/format/artifacts/source-build/self/package-cache/microsoft.codeanalysis.workspaces.msbuild/4.8.0-3.23462.3/lib/net8.0/Microsoft.CodeAnalysis.Workspaces.MSBuild.dll [/vmr/src/format/artifacts/source-build/self/src/src/dotnet-format.csproj]

This is because the change in dotnet/format#1948 hasn't made it's way into sdk via dependency flow yet. We need it in the main branch of sdk, which is .NET 9 channel but there is no .NET 9 channel in the format repo. So no dependency flow has been happening from format to sdk for main branch.

@mmitche, @sharwell - I assume format needs to be branched and a new channel created for .NET 9.

@mmitche
Copy link
Member

mmitche commented Sep 14, 2023

Yep, needs to be branched @sharwell are you the right person to do this?

@jjonescz jjonescz mentioned this pull request Sep 19, 2023
Closed
@sharwell
Copy link
Member

@mmitche, @sharwell - I assume format needs to be branched and a new channel created for .NET 9.

I'm not really sure what this means

@mmitche
Copy link
Member

mmitche commented Sep 19, 2023

@mmitche, @sharwell - I assume format needs to be branched and a new channel created for .NET 9.

I'm not really sure what this means

Format needs to be branched for .NET 8 servicing.

@marcpopMSFT
Copy link
Member

Specifically: create a release/8.0.1xx branch and make the main branch .net 9 branding

@marcpopMSFT
Copy link
Member

@mmitche The 20.23 build that this updated to of the SDK branch includes a 9.0 branded runtime but codeflow didn't update those. Are there additional changes we need to make to get the 9.0 versions of runtime and aspnet to flow to installer (I do see a bunch of .8.0 packages but updating those and then running update dependencies on the SDK channel didn't help) https://dev.azure.com/dnceng/internal/_build/results?buildId=2272452&view=results

Wasn't sure how to get those updated.

@ViktorHofer
Copy link
Member

But SDK needs the update as well probably to make source build work - dotnet/sdk#33126. cc @MiYanni

Correct, we need to get that PR in. AFAIK @MiYanni is already working on that.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231020.7
e10fd4a 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23520.7

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23519.18 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented Oct 20, 2023

There is over a week of just runtime flow backed up here so it would be ideal to solve this quickly

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231020.11
2afb7da 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23520.11

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23519.18 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented Oct 20, 2023

opened dotnet/format#1983 to revert the command-line-api flow

dotnet-maestro bot and others added 5 commits October 20, 2023 20:38
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231020.26
8f4c74e 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23520.26

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23519.18 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231020.37
fa57a5c 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23520.37

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23520.3 (parent: Microsoft.NET.Sdk
@ViktorHofer
Update Crossgen.targets
d8a68b7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231021.1
0cac364 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23521.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231021.2
4865a4a 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23521.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@ViktorHofer
Copy link
Member

Requires dotnet/sdk#36350

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231022.1
8f95030 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23522.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@ViktorHofer
Copy link
Member

microsoft.dotnet.apicompat.task/8.0.100-rc.1.23401.23

@mthalman @MichaelSimons build from source should be using a newer version of Microsoft.DotNet.ApiCompat.Task: https://github.com/dotnet/runtime/blob/e3870b0f7d20f326d0c7413f9dbfc9c42f059d9c/eng/Versions.props#L83

What's the reason for the version mismatch?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231022.2
aae810b 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23522.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231022.3
28e34f1 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23522.3

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231022.4
70bfaba 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23522.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.2
7e0f5e7 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23523.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.3
987000e 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23523.3

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.4
b293fc0 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23523.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@ViktorHofer ViktorHofer mentioned this pull request Oct 23, 2023
Merged
@ViktorHofer
Copy link
Member

I submitted dotnet/runtime#93862 to disable that specific validation during source build.

@MichaelSimons
Copy link
Member

microsoft.dotnet.apicompat.task/8.0.100-rc.1.23401.23

@mthalman @MichaelSimons build from source should be using a newer version of Microsoft.DotNet.ApiCompat.Task: https://github.com/dotnet/runtime/blob/e3870b0f7d20f326d0c7413f9dbfc9c42f059d9c/eng/Versions.props#L83

What's the reason for the version mismatch?

In source-build this dependency comes from the n-1 artifacts (previously source-built). Looks main is on rc1 because rc2 hasn't flowed. Since we are requiring a re-bootstrap in Preview1 we could like the previous source built artifacts to the current. Let me know how you would like to proceed - either lift the artifacts or go with your PR - dotnet/runtime#93862.

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 23, 2023 •
edited
Loading

I'm OK with disabling the validation via the runtime PR as this situation might come up again whenever we update APICompat to validate more than before and need to suppress it.

If you want to unblock this sooner, we could add a patch, right?

@MichaelSimons
Copy link
Member

@ViktorHofer - this same ApiCompat issue is blocking the 8.0 flow as well - #17597. We definitely can't upgrade the ApiCompat version there.

@MichaelSimons MichaelSimons mentioned this pull request Oct 23, 2023
Merged
@ViktorHofer
Copy link
Member

Changes to unblock this are now in both main and 8.0.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.7
99ee8c9 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23523.7

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.12
bc2fdde 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 9.0.100-alpha.1.23512.21 -> To Version 9.0.100-alpha.1.23523.12

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.9.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.9.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.Deployment.DotNet.Releases,Microsoft.SourceBuild.Intermediate.deployment-tools
 From Version 9.0.0-alpha.1.23477.3 -> To Version 9.0.0-alpha.1.23521.3 (parent: Microsoft.NET.Sdk
@nagilson nagilson merged commit 922a5b5 into main Oct 23, 2023
19 of 20 checks passed
@nagilson nagilson deleted the darc-main-d813792c-eeee-4e40-9f7c-567a78c653dd branch October 23, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiYanni MiYanni MiYanni approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@lewing lewing lewing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.