Add a few new WeatherHelper functions #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
krwq
reviewed
Oct 4, 2022
krwq
reviewed
Oct 4, 2022
Improve comments, add constants
krwq
reviewed
Oct 5, 2022
krwq
reviewed
Oct 6, 2022
| if (windSpeed < Speed.FromKilometersPerHour(1)) | ||
| { | ||
| // otherwise, the result is unusable, because the second and third terms of the equation are 0, resulting in a constant offset from the input temperature | ||
| windSpeed = Speed.FromKilometersPerHour(1); |
There was a problem hiding this comment.
would it make sense to just return temperature here instead? (might make function non-continous, you might want to check math)
There was a problem hiding this comment.
No, because if the wind speed is low, the returned temperature is above the input temperature. This is expected and explained in the documentation. Only if the wind speed is zero or almost zero, the formula gets completely off. So this condition basically limits the output temperature to be at most about 2 degrees over the input temperature.
krwq
approved these changes
Oct 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new functions to the
WeatherHelperclass.Microsoft Reviewers: Open in CodeFlow