-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve FT232H, add FT2232H and FT4232H #2019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some minor findings.
Maybe a namespace adjustment would be appropriate? It's hard to find the FT4232 in a folder called FT232 (there's also a FT4222...)
This is what I've tried to do: I know the names are not that easy to read without breaking what was present, so if you have a better suggestion, happy to apply it. |
The names of the classes are fine. I was just thinking about changing the namespace. I am aware that this would be a breaking change. We've done it in other places as well, but I leave it to you to decide. |
@krwq do you want to have a quick look at it or as Patrick's already reviewed it, I can go and merge it? |
This PR improves the initial work on FT232H.
It adds as well the full support for FT2232H and FT4232H.
Improvement of the documentation.
Addition for new sample.
Both 3 devices has been tested successfully with I2C using a TSL2561 sensor. GPIO pins tested including for the specific Bit Band mode on FT4232H.
Microsoft Reviewers: Open in CodeFlow