add ReselectAfterError property to MifareCard and UltralightCard #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
Ellerbach
approved these changes
Mar 29, 2023
src/devices/Card/Mifare/README.md
Outdated
| Console.WriteLine($"Tg: {decrypted.TargetNumber}, ATQA: {decrypted.Atqa} SAK: {decrypted.Sak}, NFCID: {BitConverter.ToString(decrypted.NfcId)}"); | ||
| if (decrypted.Ats is object) | ||
| Console.Write($"Tg: {decrypted.TargetNumber}, ATQA: {decrypted.Atqa} SAK: {decrypted.Sak}, NFCID: {BitConverter.ToString(decrypted.NfcId)}"); | ||
| if (decrypted.Ats is object) { |
There was a problem hiding this comment.
To be consistent with the rest
Suggested change
| if (decrypted.Ats is object) { | |
| if (decrypted.Ats is object) | |
| { |
krwq
reviewed
Mar 30, 2023
Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new property
ReselectAfterErrortoMifareCardandUltralightCard. Whentrue, if an error occurs when performing an NFC transceive operation (RunMifareCardCommandorRunUltralightCommand, respectively), callReselectCardto re-select the card. If it isfalse, the caller is responsible for reselecting the card.Update the examples in the README files.
Microsoft Reviewers: Open in CodeFlow