Improve support for AXP192 #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for all GPIO and LDO pins, fix some inconsistent namings
ghost
added
the
area-device-bindings
Start from scratch, because baseline has changed
|
How far is the code now from this one?https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Axp192 |
There where only minor API changes, so where it was different it is still different. The main change was the addition of Read/Write of all GPIO ports, which was missing on the iot implementation before. The two implementations do have quite some differences, in particular nano uses properties for I/O, where Iot prefers Get/Set methods. |
Ellerbach
reviewed
Jul 20, 2023
Very small binding at the moment, but can be extended later. Sample will be provided when everything comes together
|
[Triage] @Ellerbach can you please take another look? |
Ellerbach
approved these changes
Jul 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for all GPIO and LDO pins,
fix some inconsistent namings
Microsoft Reviewers: Open in CodeFlow