Some driver cleanup #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTasler
requested review from
krwq,
tarekgh,
jslobodzian,
joperezr,
anphel31 and
paulmon
paulmon
approved these changes
Nov 30, 2018
tarekgh
reviewed
Nov 30, 2018
src/System.Device.Gpio/Interop/Windows/WinRT/Interop.WaitForCompletion.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 30, 2018
src/System.Device.Gpio/Interop/Windows/WinRT/Interop.WaitForCompletion.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Nov 30, 2018
src/System.Device.Gpio/System/Device/Gpio/Drivers/Windows10DriverPin.Windows.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 30, 2018
joperezr
reviewed
Nov 30, 2018
src/System.Device.Gpio/System/Device/I2c/Drivers/Windows10I2cDevice.Windows.cs
Show resolved
Hide resolved
joperezr
reviewed
Nov 30, 2018
src/System.Device.Gpio/System/Device/Gpio/Drivers/Windows10Driver.Windows.cs
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Nov 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to come up with a wait to wait for WinRT
IAsyncOperationcompletions. Normally, I would use theAsTask()extension method, but that required yet another WINMD file (Windows.winmd), which then conflicts with the WINMD files that I already need.