[ci] Automatically retry failed native unit test failures once. #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Apr 13, 2023
Changes: dotnet/java-interop@a172402...554d819 * dotnet/java-interop@554d8193: [ci] Automatically retry failed native unit test failures once (dotnet/java-interop#1095) * dotnet/java-interop@71e586b0: [class-parse] Ignore `module-info.class` file. (dotnet/java-interop#1093) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jpobst
added a commit
to dotnet/android
that referenced
this pull request
Apr 17, 2023
The `apk-instrumentation` tests are a good candidate for using `retryCountOnTaskFailure`. This is because they only take a few minutes to run, and have a low enough flaky rate that it is likely that rerunning the entire test suite will succeed. As noted in dotnet/java-interop#1095, AzDO's support for this isn't perfect. The initial failure will still show up in the Error Log, however the task will be green and will not show up as a failed build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #514
There is a known native crash that occasionally occurs when running unit tests on CI: #514.
This crash doesn't happen "in the wild" so it is unlikely to get fixed anytime soon. As an workaround for our CI, we will use AzDO's
retryCountOnTaskFailureparameter to automatically re-run a native test suite once if it fails.This should reduce the need for us to re-run failed pipelines for flaky tests.
Note that AzDO's implementation isn't perfect, the task will succeed if there are no failures on retry, but the original failures will still be listed in the log. 🤷♂️
(Pipeline Run)