[Java.Interop.BootstrapTasks] Filter out invalid JDKs #1278
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonpryor's developer machines are a "weird", with a macOS arm64 box containing the directories:
$HOME/android-toolchain/jdk-17
$HOME/android-toolchain/jdk-17.x64
Meanwhile,
XAPrepareJdkLocations.GetXAPrepareJdks()
within dotnet/android-tools looks for all directories matching the glob$HOME/android-toolchains/jdk*
, and thus finds both.For some reason, the JDK that
dotnet build -t:Prepare *.sln
winds up using by default is the thejdk-17.x64
directory (😱), which cannot be loaded into an arm64 process. This results in errors fromdotnet build
:Instead of doing the "obvious" of removing
jdk.x64
or renaming it so it doesn't match the globjdk*
, updateJdkInfo.GetKnownSystemJdkInfos()
andJdkInfo.GetSupportedJdkInfos()
to filter out JDKs that cannot be loaded into the current process. This nicely filters outjdk-17.x64
, allowing dotnet/java-interop to build successfully.