Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add an "OSX .NET Core" build. #655

Merged
merged 1 commit into from
Jun 15, 2020
Merged

[CI] Add an "OSX .NET Core" build. #655

merged 1 commit into from
Jun 15, 2020

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jun 1, 2020

Adds a Mac - .NET Core build to Azure Pipelines.

Some notable changes:

  • Adds the Prepare target on Mac (.NET Core only) to move closer to what Windows uses, with the eventual goal of all systems being identical.
  • Adds the Microsoft.NETFramework.ReferenceAssemblies NuGet package to all assemblies that target net472. This allows them to be built on .NET Core, which does not have net472 framework assemblies.
  • Fixed a lot of backslashes in <Exec> tasks. Mono will fix these for us, dotnet will not.
  • Expanded jnienv-gen logic to handle running jnienv-gen.dll on dotnet in more places.

Note Mono is still used in the following cases:

  • make prepare-core uses Mono/MSBuild to build BootstrapTasks.dll to run JdkInfo.props.
  • mono jnienv-gen.exe is used when it is run from a project build targeting net472.
  • Mono headers are needed to build libjava-interop.dylib.

Eventually these first 2 uses of mono could probably be removed, But this gets us started.

@jpobst jpobst force-pushed the build-dotnet-core branch 12 times, most recently from 6f2a69d to b0baf82 Compare June 3, 2020 14:16
@jpobst jpobst force-pushed the build-dotnet-core branch 18 times, most recently from fd285e6 to b4d4d57 Compare June 10, 2020 16:14
@jpobst jpobst force-pushed the build-dotnet-core branch 6 times, most recently from 3ef232b to f6755e5 Compare June 12, 2020 16:30
@jpobst jpobst marked this pull request as ready for review June 12, 2020 16:52
@jpobst jpobst requested a review from jonpryor June 12, 2020 16:52
@jonpryor jonpryor merged commit 1de5501 into master Jun 15, 2020
@jonpryor jonpryor deleted the build-dotnet-core branch June 15, 2020 17:48
@jpobst jpobst added this to the 10.5 (16.8 / 8.8) milestone Jun 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants