[java-source-utils] Properly represent unresolved types #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #687 (comment)
Commit 69e1b80 stated:
…except this didn't actually happen:
java-source.utils.jar --output-javadoc
didn't have anL
prefixand
;
suffix for the JNI type representation. Additionally, itwould include generic type parameters!
Thus, a declaration such as:
would result in:
which was not at all intended, and causes subsequent issued in PR #687
as the JNI signature parser would break when encountering
.
.Update
java-source-utils.jar
&//*/@jni-signature
so thatunresolved types are properly represented:
//*/@jni-type
and//*/@jni-signature
shouldn't contain generic type parameters, andshould also (somewhat) "conform" to JNI convention, with a leading
L
and trailing
;
, emitting:Additionally, update
JavaType.java
to cause it to have "orphaned"Javadoc comments; this change was forgotten in c1bc5c8.